Fix OpenHands direct execution outside root workdirs#932
Merged
Conversation
Collaborator
Author
|
Additional local validation after the root-user follow-up commit
The fix is intentionally runtime-only; manifest parity remains green because the published OpenHands launch contract is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/appworkdirs so ACP startup no longer depends on chowning/rootValidation
uv run pytest -q tests/test_acp.py tests/test_agent_registry.py tests/test_acp_setup_failure_propagation.py tests/agents/test_manifest_parity.py(122 passed, 2 skipped)uv run ruff check src/benchflow/acp/runtime.py tests/test_acp.pyuv run ruff format --check src/benchflow/acp/runtime.py tests/test_acp.pyuv run ty check src/benchflow/acp/runtime.pyFollow-up to #921. The prior launch-time mutation ran as the sandbox user and failed on task images whose workdir was not
/root, leaving empty ACP and no model calls.