Skip to content

Fix OpenHands direct execution outside root workdirs#932

Merged
bingran-you merged 2 commits into
mainfrom
bry/openhands-direct-execution-prelaunch
Jul 15, 2026
Merged

Fix OpenHands direct execution outside root workdirs#932
bingran-you merged 2 commits into
mainfrom
bry/openhands-direct-execution-prelaunch

Conversation

@bingran-you

Copy link
Copy Markdown
Collaborator

Summary

  • apply the opt-in OpenHands subagent-disable patch through the root execution plane before sandbox-user privilege drop
  • pass a copied launch environment with the duplicate user-space patch disabled
  • cover /app workdirs so ACP startup no longer depends on chowning /root

Validation

  • uv run pytest -q tests/test_acp.py tests/test_agent_registry.py tests/test_acp_setup_failure_propagation.py tests/agents/test_manifest_parity.py (122 passed, 2 skipped)
  • uv run ruff check src/benchflow/acp/runtime.py tests/test_acp.py
  • uv run ruff format --check src/benchflow/acp/runtime.py tests/test_acp.py
  • uv run ty check src/benchflow/acp/runtime.py

Follow-up to #921. The prior launch-time mutation ran as the sandbox user and failed on task images whose workdir was not /root, leaving empty ACP and no model calls.

@bingran-you bingran-you had a problem deploying to pypi-internal-preview July 15, 2026 05:16 — with GitHub Actions Failure
@bingran-you bingran-you deployed to pypi-internal-preview July 15, 2026 05:22 — with GitHub Actions Active
@bingran-you

Copy link
Copy Markdown
Collaborator Author

Additional local validation after the root-user follow-up commit 832d0a20f:

  • uv run pytest -q tests/4899 passed, 16 skipped, 7 deselected
  • focused OpenHands pre-launch tests → 2 passed
  • Ruff check/format and ty remain green

The fix is intentionally runtime-only; manifest parity remains green because the published OpenHands launch contract is unchanged.

@bingran-you bingran-you merged commit 2177c43 into main Jul 15, 2026
9 checks passed
@bingran-you bingran-you deleted the bry/openhands-direct-execution-prelaunch branch July 15, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant