Replace through2 with core stream.PassThrough#52
Merged
Conversation
through2 was only used as a no-arg passthrough for .json files. Node's built-in stream.PassThrough does the same thing, so drop the dependency instead of chasing its v5 ESM rewrite. Keeps the package CommonJS and removes a maintenance dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
through2dependency. It was used in one place: a no-arg passthrough stream for.jsonfiles in the browserify transform. Node's built-instream.PassThroughis exactly that, so there's no reason to carry the dependency.through2 5.0.0 is an ESM rewrite. Adopting it would mean either bumping the engine floor to Node 22.12+ (its
require()support) or converting this package to ESM, and neither is warranted for a CommonJS-focused library in maintenance mode. Dropping through2 sidesteps that entirely and keeps everything CommonJS on the existingenginesrange.Verified the
.jsonpassthrough emits input unchanged, and the fullstandard+tapesuite passes (12/12).Supersedes #51, which Dependabot should auto-close once this merges and the dependency is gone.