Skip to content

Editor text copy - new behavior#100

Merged
benfry merged 2 commits intobenfry:masterfrom
urbanskimichal:whole_line_copy
Jan 15, 2022
Merged

Editor text copy - new behavior#100
benfry merged 2 commits intobenfry:masterfrom
urbanskimichal:whole_line_copy

Conversation

@urbanskimichal
Copy link
Copy Markdown
Contributor

@urbanskimichal urbanskimichal commented May 10, 2020

This is proposal of the feature that I personally miss the most in PDE - copying / cutting whole lines.
When no text is selected and one presses Ctrl+c (Cmd+c) or Ctrl+x (Cmd+x), the whole text in the line on which the caret is, will be coped or cut.
It allows for easy lines duplicating etc.

* Selects all text in the given line.
* @param line The line number to select all text in it.
*/
public final void selectLine(final int line)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @urbanskimichal! I think I'm in favor of the change if it isn't confusing to new users (I don't think it would be, it's common behavior for a lot of editors). However, could you say more about why you made this public?

@sampottinger
Copy link
Copy Markdown
Collaborator

sampottinger commented Jul 1, 2020

Hey there @urbanskimichal! I am doing a integration build so I modified the above to private. It's still ok to change back but wanted to make that edit before bringing this branch into integration. That is not reflected in your fork.

@sampottinger
Copy link
Copy Markdown
Collaborator

See urbanskimichal#1

@sampottinger
Copy link
Copy Markdown
Collaborator

This is available on an integration branch at https://github.com/sampottinger/processing4 (master) for testing in the context of other open PRs with a community build at https://www.datadrivenempathy.com/processing.

@benfry
Copy link
Copy Markdown
Owner

benfry commented Jan 11, 2022

If we can get a rebased version with that change to private, I can incorporate this.

@urbanskimichal
Copy link
Copy Markdown
Contributor Author

I resolved conflicts, should I do anything else? What does it mean "to private"?

@sampottinger
Copy link
Copy Markdown
Collaborator

sampottinger commented Jan 15, 2022

I think @benfry wants selectLine to be made into a private method instead of a public method? (If it’s possible)

@benfry benfry merged commit 1bb6911 into benfry:master Jan 15, 2022
benfry added a commit that referenced this pull request Jan 15, 2022
@benfry
Copy link
Copy Markdown
Owner

benfry commented Jan 15, 2022

All set for beta 4; thanks!

@urbanskimichal
Copy link
Copy Markdown
Contributor Author

So the change is included?

@benfry
Copy link
Copy Markdown
Owner

benfry commented Jan 17, 2022

It will be in beta 4, the next release.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked. Pull requests that have been closed are automatically locked 30 days after the last comment.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants