Open
Conversation
added 5 commits
February 9, 2024 17:26
greater circle does not interfere with pieces. unused code removed
Owner
|
Are there other software that mark squares with a rectangle? How do they handle %csl?" |
Contributor
Author
|
Chessbase use rounded rectangles: https://help.chessbase.com/CBase/17/Eng/graphic_commentary.htm?zoom_highlightsub=mark%2Bsquare |
Owner
Interesting. |
Contributor
Author
|
Lichess uses circles: https://lichess.org/study/jTcC0b7Q/rVqUvSQd |
f96d38b to
404bda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mark "square" is defined but not implemented : "variable Type {full|square|arrow|circle|disk|tux}"
This implements drawSquare and use it for %csl, set it for standard in comment editor. This mark shows a rectangle.
Advantage: the mark from pgn data and a mark from colorsquare (used by gloss of danger and suggested move) can displayed together.
The size is a little bit smaller than a square to show also the rectangle from "highlight last move".
The function of the mark "full" is not touched.