Propagate flagUnion into incremental stream/defer buckets and add tests#4
Open
Propagate flagUnion into incremental stream/defer buckets and add tests#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
flagUnioncorrectly reflects pre-populatedstoreentries when building incremental stream/defer buckets so downstream filtering and dependency checks observe error/inhibited flags.Description
getFlagUnionFromStore(store: Bucket["store"])which aggregates_getStateUnion()from eachExecutionValuein astoreand returns anExecutionEntryFlagsunion.flagUnion: getFlagUnionFromStore(store)instead ofNO_FLAGSin both stream (processStream/_processQueue) and deferred (processSingleDeferred/specs) code paths.ExecutionEntryFlagstype where needed and kept existing behaviour otherwise unchanged.grafast/grafast/__tests__/flagUnionIncremental-test.tsthat assert error flags (viaflagError/TRAP_ERROR) are visible inside newly-created stream and deferred buckets by using a customFlagUnionCheckStepthat inspects_extra._bucket.flagUnion.Testing
__tests__/flagUnionIncremental-test.tscovering the streaming case and the deferred case, both asserting that no unexpectederrorspayloads are emitted and the merged data matches expected results; these tests were added to the test suite.Codex Task