Skip to content

fix: unpaused line draws ahead of dot #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barvian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: unpaused line draws ahead of dot #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/useLivelineEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,9 +732,14 @@ export function useLivelineEngine(
const rightEdge = now + windowSecs * buffer
const leftEdge = rightEdge - windowSecs

// Filter visible points — when pausing, contract right edge to `now`
// so new data (with real-time timestamps) can't appear past the live dot
const filterRight = rightEdge - (rightEdge - now) * pauseProgress
// Filter visible points — when pausing, contract right edge to `now`
// so new data (with real-time timestamps) can't appear past the live dot.
// While draining time debt (catch-up), also cap at `now` — data from the
// pause period has real-time timestamps ahead of the chart's lagging `now`,
// and letting those through would place points past the live tip, breaking
// the spline's monotone-X assumption and causing the line to loop backward.
const rawFilterRight = rightEdge - (rightEdge - now) * pauseProgress
const filterRight = timeDebtRef.current > 0.01 ? Math.min(now, rawFilterRight) : rawFilterRight
const visible: LivelinePoint[] = []
for (const p of effectivePoints) {
if (p.time >= leftEdge - 2 && p.time <= filterRight) {
Expand Down