Add GOES and cleanup dimension selection#8
Merged
Conversation
Collaborator
jordanschnell
commented
Apr 13, 2026
jordanschnell
commented
- Adds the capability to interpolate GOES L2 data (requires a temporary workaround using xarray)
- Uses time/level sizes to determine function args rather than dataset names.
…ndency on dataset
benkozi
requested changes
Apr 14, 2026
| ds_averaged.to_netcdf(Path(output_dir + '/test_goes_aod_merged.nc')) | ||
|
|
||
| if not rave_paths: | ||
| print(f"No matching GOES files found for {date_to_process} (even after lookback).") |
Owner
There was a problem hiding this comment.
You could raise a ValueError here instead of print + exit.
Comment on lines
+1365
to
+1366
| print("will cat files: ") | ||
| print(files_to_cat) |
Owner
There was a problem hiding this comment.
Best to use _LOGGER.info or _LOGGER.debug as opposed to prints
|
|
||
| # JLS - temporary fix for coords not in file | ||
| if self.context.dataset_name == "GOES": | ||
| pathsrc="/scratch4/BMC/acomp/cheMPAS-Fire/input/grids/domain_latlons/goes19_abi_conus_interpolated_lat_lon.nc" |
Owner
There was a problem hiding this comment.
Will you want this to run on Gaea-C6?
Collaborator
Author
|
Hi Ben, thanks for the change suggestions. Will get these done when Ursa is back up including addressing the extra domain_latlon hardcoded to Ursa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.