Skip to content

feat(ddk-manager): add DDK_ALLOW_UNCONFIRMED_SPLICE env var for 0-conf splice #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthewjablack wants to merge 1 commit into from
Closed

feat(ddk-manager): add DDK_ALLOW_UNCONFIRMED_SPLICE env var for 0-conf splice #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ddk-manager/src/dlc_input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ use crate::{
contract::Contract, error::Error, ContractId, ContractSigner, ContractSignerProvider, Storage,
};

/// Check if unconfirmed (Signed) contracts are allowed for DLC input signing.
/// Set DDK_ALLOW_UNCONFIRMED_SPLICE=true to enable 0-conf splice operations.
fn allow_unconfirmed_splice() -> bool {
std::env::var("DDK_ALLOW_UNCONFIRMED_SPLICE")
.map(|v| v.to_lowercase() == "true" || v == "1")
.unwrap_or(false)
}

// todo: definitely test
/// Get the DlcInputInfo from FundingInputs
pub fn get_dlc_inputs_from_funding_inputs(funding_inputs: &[FundingInput]) -> Vec<DlcInputInfo> {
Expand Down Expand Up @@ -44,8 +52,18 @@ where
"Contract not found to sign DLC input.".to_string(),
))?;

// Extract keys_id from contract based on state.
// By default, only Confirmed contracts are allowed for DLC input signing.
// Set DDK_ALLOW_UNCONFIRMED_SPLICE=true to also allow Signed contracts
// (funding tx in mempool but not yet confirmed). Useful for testnets and 0-conf operations.
let key_id = match contract {
Contract::Confirmed(c) => Ok(c.accepted_contract.offered_contract.keys_id),
Contract::Signed(s) if allow_unconfirmed_splice() => {
Ok(s.accepted_contract.offered_contract.keys_id)
}
Contract::Signed(_) => Err(Error::InvalidState(
"Contract must be confirmed to sign DLC input. Set DDK_ALLOW_UNCONFIRMED_SPLICE=true for 0-conf splice.".to_string(),
)),
_ => Err(Error::InvalidState(
"Contract must be confirmed to sign DLC input.".to_string(),
)),
Expand Down
Loading