Avoid setting up a timer if it's unneeded#98
Open
deltab wants to merge 1 commit intobenpickles:mainfrom
Open
Conversation
This change checks whether there are any `updating-chart` elements on a page before setting up the timer that updates them. Obviously the check is unnecessary on *this* page, but the demo script gets copied into themes etc. and ends up loaded on pages that don't have any updating charts, wasting CPU time and electricity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change checks whether there are any
updating-chartelements on a page before setting up the timer that updates them.Obviously the check is unnecessary on this page, but the demo script gets copied into themes etc. and ends up loaded on pages that don't have any updating charts, wasting CPU time and electricity.