Conversation
…cumentation generation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds significant new features to the placeholder management system: caching support via @Cache annotation, middleware processing via @Middleware annotation, permission requirements via @RequirePermission annotation, and automatic documentation generation. It also enhances existing annotations with description and example fields.
Key Changes
- Introduces three new annotations (
@Cache,@Middleware,@RequirePermission) and a middleware interface for extensible placeholder processing - Refactors caching logic to support configurable cache durations with TimeUnit-based control
- Adds
generateDocs()method to automatically create documentation files listing all registered placeholders with their metadata
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
PlaceholderMiddleware.java |
New functional interface for processing placeholder results before returning to PlaceholderAPI |
RequirePermission.java |
New annotation for permission-gated placeholders with customizable denial messages |
RelationalPlaceholder.java |
Added optional description and example fields for documentation generation |
PlaceholderIdentifier.java |
Added optional description and example fields for documentation generation |
Middleware.java |
New annotation to specify middleware chain for placeholder result processing |
Cache.java |
New annotation for configurable caching with duration and TimeUnit support |
BenthPAPIManager.java |
Major refactoring: added middleware support, permission checking, improved caching logic, and documentation generation functionality |
.gitignore |
Added dependency-reduced-pom.xml to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.