Some of the patches we talked about#57
Open
cfedde wants to merge 6 commits intoberekuk:masterfrom
cfedde:master
Open
Some of the patches we talked about#57cfedde wants to merge 6 commits intoberekuk:masterfrom cfedde:master
cfedde wants to merge 6 commits intoberekuk:masterfrom
cfedde:master
Conversation
lib/Ubic/Admin/Setup.pm
Outdated
Owner
There was a problem hiding this comment.
Are you sure it should be 0002 and not 0022?
I understand root usually belongs to a special group, root or wheel, and it makes sense to allow everyone from this special group to edit these files.
But Ubic often gets installed from non-root users, into ~, and allowing everyone in users group to edit its files is a mistake.
I also checked my OSX system and Ubuntu 12.04, both default to 0022 root umask.
Author
There was a problem hiding this comment.
I'll make it 0022. That is permissive enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated this to match the discussion.