fix(core): detect package manager properly using @nx/devkit (Fixes #74)

[michaelbe812]

Summary

• Replace custom package manager detection with @nx/devkit's detectPackageManager and getPackageManagerCommand functions
• The previous implementation checked for globally available binaries (pnpm -v, yarn -v) which didn't respect the project's actual configuration
• Now correctly detects based on lock files (package-lock.json, yarn.lock, pnpm-lock.yaml) and packageManager field in package.json

Test plan

• All existing auto-installer tests pass (21 tests)
• All core package tests pass (154 tests)
• All plugin-openapi tests pass (32 tests)
• Linting passes for core and plugin-openapi packages
• Verify detectPackageManager() returns correct value based on lock file

Closes #74

🤖 Generated with Claude Code

[michaelbe812]

Code Review Summary ✅

Overview

This is a well-implemented fix that correctly addresses issue #74. The change from custom package manager detection to using @nx/devkit's built-in functions is the right approach.

What I Reviewed

• ✅ Implementation in auto-installer.ts - Clean delegation to @nx/devkit
• ✅ Test coverage in auto-installer.spec.ts - Properly mocks @nx/devkit functions
• ✅ All tests pass (154 tests in core package)
• ✅ Linting passes

Key Improvements

1. Correct approach - Using @nx/devkit's detectPackageManager properly checks:

   • Lock files (pnpm-lock.yaml, yarn.lock, package-lock.json)
   • packageManager field in package.json

2. Simpler implementation - Reduced from ~18 lines to ~4 lines of logic

3. More reliable - Previous implementation checked for globally available binaries (pnpm -v, yarn -v) which could incorrectly detect a package manager not actually used by the project

4. Maintains API compatibility - Re-exports PackageManager type correctly

5. Good documentation - Clear JSDoc comment explaining the function

Code Quality

The implementation is clean and follows best practices. Tests properly isolate the unit under test by mocking @nx/devkit dependencies.

Verdict: LGTM! Ready to merge. 🎉

---

Automated code review by Claude Code