Skip to content

fix: include error_description in PKCE callback error page - #24

Merged
marcusolsson merged 1 commit into
mainfrom
fix/issue-4-error-description-in-callback
May 21, 2026
Merged

fix: include error_description in PKCE callback error page#24
marcusolsson merged 1 commit into
mainfrom
fix/issue-4-error-description-in-callback

Conversation

@marcusolsson

Copy link
Copy Markdown
Contributor

Issue 4 from TODO.md

Keycloak OAuth error responses include both an error code and an error_description. The callback handler only displayed the error code, giving users vague messages like "Authentication failed: access_denied" without actionable context.

Changes

  • Extract error_description from the callback query string.
  • Concatenate error and error_description for display when both are present.
  • Uses ${error}: ${errorDescription} format so the browser HTML page and the resolved error string both include the human-readable explanation.
  • Adds 2 regression tests: one with error_description, one without.

Refs: TODO.md Issue 4

@marcusolsson
marcusolsson merged commit dd3550e into main May 21, 2026
1 check passed
@marcusolsson
marcusolsson deleted the fix/issue-4-error-description-in-callback branch May 21, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant