fix: include error_description in PKCE callback error page - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 4 from TODO.md
Keycloak OAuth error responses include both an
errorcode and anerror_description. The callback handler only displayed theerrorcode, giving users vague messages like"Authentication failed: access_denied"without actionable context.Changes
error_descriptionfrom the callback query string.erroranderror_descriptionfor display when both are present.${error}: ${errorDescription}format so the browser HTML page and the resolved error string both include the human-readable explanation.error_description, one without.Refs: TODO.md Issue 4