fix: validate refresh token exchange response at runtime - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 12 from TODO.md
The
refreshAccessTokenInternalfunction used an unchecked TypeScriptascast after parsing the refresh response. If the Berget/v1/auth/refreshendpoint (or a proxy) returns a 200 OK with a malformed body, the plugin storesundefinedas the new access token and overwrites the previously valid token in OpenCode's persistent storage.Changes
ascast with explicittypeofruntime validation fortokenandexpires_in.{success: false, reason: 'Invalid token response from refresh endpoint'}on malformed bodies.typeof data.refresh_token === 'string'to safely extract rotated refresh tokens.token, wrongexpires_intype, and proxy-wrapped error body.Refs: TODO.md Issue 3 (same pattern) / Issue 12