chore: use Web Crypto API for PKCE random generation - #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 10 from TODO.md
The PKCE flow used Node.js's older
crypto.randomBytes()for generating thecode_verifierandstatenonce. While synchronous and fast for small sizes,crypto.webcrypto.getRandomValuesis the idiomatic, non-blocking, Web-API-compatible choice on Node 18+.Changes
crypto.randomBytes(32).toString('base64url')withcrypto.webcrypto.getRandomValues(new Uint8Array(32))+Buffer.from(bytes).toString('base64url').generateRandomHex(byteLength)helper using the same Web Crypto API for thestatenonce.generateCodeVerifier()for unit testing.Refs: TODO.md Issue 10