refactor(makefile): consolidate docker-up variants behind PROFILE param#167
Merged
saschagobel merged 3 commits intotest/annotation-fixture-isolationfrom Apr 30, 2026
Merged
Conversation
fc9d4b1 to
451befd
Compare
d1ec69c to
1418d91
Compare
saschagobel
approved these changes
Apr 30, 2026
Collaborator
saschagobel
left a comment
There was a problem hiding this comment.
Approved — the refactor is sound and simplifies the Makefile nicely; only one non-blocking cleanup comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Replace four near-identical
docker-up*Makefile targets with a single parameterisedmake docker-up PROFILE=<name>. Reduces duplication, makes the profile choice explicit at the call site, and aligns with the principle that the Makefile passes through to the underlying compose CLI rather than baking configuration into target names.Scope
Makefileonly.Before:
After:
Implementation
PROFILE ?= all-bundledmakesall-bundledthe default while allowing override on the command line.casestatement in the recipe routes byPROFILE:--profileflag (or empty forexternal).ARGILLA_DATABASE_URLforexternal-pg, etc.).down/stop/logs/statusstill use$(ALL_PROFILES)so they affect every profile's containers regardless of which one started the stack.Testing
make docker-up(default) → starts stack asall-bundled. Argilla up at :6900 — verified.make docker-up PROFILE=garbage→Error: unknown PROFILE 'garbage' (valid: all-bundled, external-pg, external-es, external), exit 1.make docker-up PROFILE=external-pg(withoutARGILLA_DATABASE_URLin.env) →Error: ARGILLA_DATABASE_URL must be set for PROFILE=external-pg, exit 1.make cigreen (598 passed, 39 deselected).make test-allgreen (637 passed).tests/unit/test_dev_stack.py::test_makefile_defines_expected_targetsstill passes — the unit test only pins canonical targets (docker-up,docker-down, etc.), not the variant targets that this PR removes.References