ci: single-source Boost/Eigen/eigenpy versions; bumps trigger the image - #278
Merged
Conversation
Add .github/ci-deps-versions.env as the ONE place the C++ dep versions live, read by all three CI workflows: - build_and_test.yml: a small `set_versions` job reads the file and exposes boost/eigen/ eigenpy as outputs; the two jobs that build from source (test_cpp_unix, build_macos_ubuntu_wheels) consume them as job-level env. Removed the workflow-level BOOST_VERSION/EIGENPY_VERSION and the hardcoded eigen-3.4.0 literals. - build-ci-image.yml / build-macos-deps.yml: load the file into $GITHUB_ENV per job, and add the file to their push path filters. So a version bump in one file (a) reruns build_and_test, (b) rebuilds the Linux image, and (c) rebuilds the macOS tarballs -- no more editing versions in four places, and no more forgetting to rebuild the prebuilt deps after a bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One file —
.github/ci-deps-versions.env— now holds the C++ dep versions, read by all three CI workflows:set_versionsjob reads the file and exposesboost/eigen/eigenpyas outputs; the two jobs that build from source (test_cpp_unix,build_macos_ubuntu_wheels) consume them as job-level env (works for both${{ env.X }}and shell$X). Dropped the workflow-level version env and the hardcodedeigen-3.4.0literals.$GITHUB_ENVper job, and add it to their push path filters.Payoff: a version bump in one file (a) reruns build_and_test, (b) rebuilds the Linux image, and (c) rebuilds the macOS tarballs — no editing four places, no forgetting to rebuild the prebuilt deps after a bump.
Validated: all three workflows parse;
grepfinds zero version literals left outside the .env. Theset_versionsenv plumbing gets exercised by this PR's own CI. Hold merge per the develop-merge freeze.🤖 Generated with Claude Code