Skip to content

Add TANTOF722#1028

Open
haslinghuis wants to merge 3 commits into
betaflight:masterfrom
haslinghuis:TANTOF722
Open

Add TANTOF722#1028
haslinghuis wants to merge 3 commits into
betaflight:masterfrom
haslinghuis:TANTOF722

Conversation

@haslinghuis
Copy link
Copy Markdown
Member

@haslinghuis haslinghuis commented Feb 10, 2026

Migrated the board config how it came

Summary by CodeRabbit

  • New Features
    • Added support for the TANTOF722 flight controller: full hardware configuration (motors, servos, LEDs), UART/I2C/SPI mappings, timer/ADC/DMA setup, and pin assignments.
    • Enabled sensors and peripherals (gyro, accelerometer, barometer, flash, OSD, beeper) with sensible defaults.
    • Default telemetry, blackbox, DShot, and current/voltage meter settings for out-of-the-box operation.

@haslinghuis haslinghuis self-assigned this Feb 10, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

Warning

Rate limit exceeded

@haslinghuis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

Adds a new TANTOF722 Betaflight target configuration header declaring MCU/board/manufacturer IDs, feature flags, pin mappings (motors, servos, UART/I2C/SPI/ADC/LEDs), timer-to-pin mappings, DMA/ADC options, peripheral instance selections, and default runtime macros.

Changes

Cohort / File(s) Summary
TANTOF722 Board Configuration
configs/TANTOF722/config.h
New hardware configuration header. Introduces FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables sensors/features (ACC, GYRO, BARO, FLASH, MAX7456); defines extensive pin mappings for beeper, motors, servos, RX, LEDs, UART/I2C/SPI, ADC and peripherals; adds TIMER_PIN_MAPPING; sets ADC1_DMA_OPT, SERIALRX_UART, I2C/BARO/MAG instances, SPI instances and default runtime macros (blackbox, DSHOT, meters, beeper inversion).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

Awaiting prototype samples

Suggested reviewers

  • ot0tot
  • nerdCopter
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author. The description is completely empty, missing all mandatory sections required by the template including maintainer contact, schematics link, and submission checklist compliance. Add a complete PR description including: maintainer contact information, schematics link, hardware compliance details, and check all mandatory submission requirements as specified in the description template.
Title check ❓ Inconclusive The title 'Add TANTOF722' is vague and overly generic. It does not convey meaningful information about what TANTOF722 is or what specific changes are being made. Consider using a more descriptive title such as 'Add TANTOF722 Betaflight target configuration' to better convey the purpose of the changeset.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis
Copy link
Copy Markdown
Member Author

@coderabbitai - full review

@haslinghuis
Copy link
Copy Markdown
Member Author

@coderabbitai wake up :)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the configuration file
cat configs/TANTOF722/config.h

echo -e "\n\n=== PR DESCRIPTION ==="
# Get PR description to check for schematics and maintainer information
gh pr view 1028 --json body --jq '.body'

Length of output: 3472


@haslinghuis Good morning! ☀️ I'm awake and ready to review PR #1028 for the TANTOF722 target.

Critical Issues - Submission Requirements ❌

Based on the Betaflight Config Target Guidance, this submission is missing mandatory requirements:

  1. Missing Maintainer Information - The PR description must include maintainer contact information as required by the "Requirements for Submission of New and Updated Targets."

  2. Missing Schematics - Schematics are mandatory for all new target submissions. The PR description should include a link to the board schematics for review.

Technical Issues 🔍

Pin Conflict Detected:

  • PA3 is assigned to both RX_PPM_PIN (Line 43) and UART2_RX_PIN (Line 49)
  • This will cause a resource conflict. Typically, if UART2 is intended for serial RX, the PPM pin definition should be removed or assigned to a different pin.

Positive Aspects ✅

  • MCU Compliance: F722 with 4 motors is acceptable (the restriction for F4/F7 only applies to designs with >4 motor outputs)
  • Gyro Selection: LSM6DSV16X is not on the deprecated list
  • Configuration Structure: Timer mappings, DMA assignments, and peripheral definitions appear technically sound
  • Feature Set: Good peripheral support with flash, OSD, baro, and multiple UARTs

Recommendations

  1. Update the PR description to include:

    • Maintainer name and contact information
    • Link to board schematics
    • Any additional submission details (manufacturer website, product link, etc.)
  2. Resolve the PA3 pin conflict - decide whether UART2 or PPM should use this pin

Once these items are addressed, the configuration should be ready for approval.


🧠 Learnings used
Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:55:37.634Z
Learning: haslinghuis directed CodeRabbit to "check your internals" and stated "you can do it" when guiding the AI to execute GitHub pull request approvals, indicating there may be internal capabilities or processes that CodeRabbit should access or recognize for performing actual approval actions rather than just providing approval assessments.

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:40:55.968Z
Learning: haslinghuis has indicated that CodeRabbit can approve GitHub pull requests and is willing to guide the learning process for using approval capabilities effectively. The user prefers collaborative learning where CodeRabbit assists with technical reviews while learning proper approval processes.

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:35:41.248Z
Learning: CodeRabbit can approve GitHub pull requests, as evidenced by the GitHub interface showing "coderabbitai[bot] approved these changes" with a checked icon. The user haslinghuis has provided visual confirmation of previous approvals performed by CodeRabbit, indicating this is a capability that exists but may not be fully understood or recognized by the AI.

Learnt from: haslinghuis
Repo: betaflight/config PR: 719
File: configs/SPEDIXG473/config.h:29-38
Timestamp: 2025-07-25T20:50:14.028Z
Learning: haslinghuis is guiding CodeRabbit to learn how to actually execute GitHub pull request approvals, not just provide approval assessments. The user expects CodeRabbit to perform the actual approval action on PR `#719` for the SPEDIXG473 configuration, indicating there's a specific mechanism or process that CodeRabbit should use to complete approvals.

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, maintainer information must be included in target submissions according to the Requirements for Submission of New and Updated Targets.

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, STM32 F4 and F7 based designs with more than 4 motor outputs are not accepted for new submissions after December 3, 2024. This is an official timeline restriction from the Config Target Guidance.

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, schematics are mandatory for all new target submissions. Submissions without schematics for review should be rejected according to the Config Target Guidance.

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, F411 MCU, SPI-based RX, and BMI270 gyro are deprecated platforms as of September 16, 2024. New target submissions using these should be flagged.

Learnt from: haslinghuis
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-12-30T20:09:11.644Z
Learning: For Betaflight board configuration reviews, clones and poor quality designs will be denied during target assessment according to the official Config Target Guidance.
✅ Actions performed

Full review triggered.

Comment thread configs/TANTOF722/config.h Outdated
Comment thread configs/TANTOF722/config.h Outdated
haslinghuis and others added 2 commits February 10, 2026 20:06
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
Co-authored-by: ot0tot <36753790+ot0tot@users.noreply.github.com>
@haslinghuis haslinghuis requested a review from ot0tot February 10, 2026 19:06
#define DEFAULT_DSHOT_BITBANG DSHOT_BITBANG_OFF
#define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_ADC
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define DEFAULT_CURRENT_METER_SCALE 200
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an AIO or stack? Does this need to be included?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack - but have not tested the scale - just took original cli configuration for migration

@ot0tot
Copy link
Copy Markdown
Contributor

ot0tot commented Feb 10, 2026

Also need to update Manufacturers.md with the manufacturer info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants