Add MICOAIR743V2#1059
Conversation
WalkthroughAdded a new Betaflight board configuration header for the MICOAIR743V2 flight controller based on the STM32H743 MCU. The file defines pin mappings for motors, UARTs, I2C, SPI, ADC, and SD card interfaces, along with hardware feature flags for accelerometer, gyro (BMI270), barometer (DPS310), SD card support, and MAX7456 OSD. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🧹 Nitpick comments (1)
configs/MICOAIR743V2/config.h (1)
108-131: LGTM!Peripheral configuration is well-structured:
- Gyro (SPI3) and MAX7456 OSD (SPI1) on separate SPI buses, avoiding blocking conflicts
- Barometer and magnetometer properly distributed across I2C buses
- Conditional UART assignments for HD OSD and GPS are appropriate
Nitpick: Add trailing newline
`#define` USE_SPI_GYRO `#define` GYRO_1_SPI_INSTANCE SPI3 +🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@configs/MICOAIR743V2/config.h` around lines 108 - 131, The file ends without a trailing newline; add a single newline character at EOF immediately after the final preprocessor line (e.g., after "#define GYRO_1_SPI_INSTANCE SPI3") so the file ends with a newline to satisfy POSIX/text-file conventions and prevent tooling diffs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@configs/MICOAIR743V2/config.h`:
- Around line 26-27: Add a maintainer comment to configs/MICOAIR743V2/config.h
near the top where BOARD_NAME and MANUFACTURER_ID are defined: include
maintainer name and contact (GitHub handle or email) in a single-line or block
comment directly above or below the `#define` lines (e.g., reference BOARD_NAME
and MANUFACTURER_ID) so the target contains required maintainer metadata.
---
Nitpick comments:
In `@configs/MICOAIR743V2/config.h`:
- Around line 108-131: The file ends without a trailing newline; add a single
newline character at EOF immediately after the final preprocessor line (e.g.,
after "#define GYRO_1_SPI_INSTANCE SPI3") so the file ends with a newline to
satisfy POSIX/text-file conventions and prevent tooling diffs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b8430fbc-3d0e-4ddf-9bbd-0b274feffecc
📒 Files selected for processing (1)
configs/MICOAIR743V2/config.h
| #define BOARD_NAME MICOAIR743V2 | ||
| #define MANUFACTURER_ID MICO |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify MICO is a registered manufacturer
rg -n "^MICO#" Manufacturers.md || echo "MICO not found in Manufacturers.md"Repository: betaflight/config
Length of output: 95
🏁 Script executed:
# Check Manufacturers.md format and content
head -50 Manufacturers.md
echo "---"
# Check if MICO appears anywhere in the repo
rg -i "mico" --type-list
rg -i "mico" configs/ -A 2 -B 2 | head -30Repository: betaflight/config
Length of output: 4034
🏁 Script executed:
# Check the full config.h file to identify other potential issues
wc -l configs/MICOAIR743V2/config.hRepository: betaflight/config
Length of output: 94
🏁 Script executed:
# Read the full new config.h
cat -n configs/MICOAIR743V2/config.h | head -40
echo "---"
# Check if MICOAIR743 (existing) has maintainer info
grep -i "maintainer\|author\|github" configs/MICOAIR743/config.h || echo "No maintainer info found in MICOAIR743"
echo "---"
# Check git log for MICOAIR743 to see if it was merged
git log --oneline --all -- configs/MICOAIR743/config.h 2>/dev/null | head -5Repository: betaflight/config
Length of output: 1601
🏁 Script executed:
# Check if MICO should be added to Manufacturers.md - search for any documentation/PR about it
git log --oneline --all --grep="MICO" 2>/dev/null | head -10
git log --oneline --all -- Manufacturers.md 2>/dev/null | head -10Repository: betaflight/config
Length of output: 671
🏁 Script executed:
# Search for MICO in Manufacturers.md with correct delimiter pattern
grep -n "MICO" Manufacturers.md
echo "---"
# Also check current state
cat Manufacturers.md | grep -E "^\|MICO\|"Repository: betaflight/config
Length of output: 149
🏁 Script executed:
# Check the full Manufacturers.md to see all entries
wc -l Manufacturers.mdRepository: betaflight/config
Length of output: 81
Add maintainer information.
Maintainer information is required for target submissions according to the Requirements for Submission of New and Updated Targets. Please add a comment with maintainer details (name, GitHub handle, or email).
Note: The manufacturer ID MICO is properly registered in Manufacturers.md.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@configs/MICOAIR743V2/config.h` around lines 26 - 27, Add a maintainer comment
to configs/MICOAIR743V2/config.h near the top where BOARD_NAME and
MANUFACTURER_ID are defined: include maintainer name and contact (GitHub handle
or email) in a single-line or block comment directly above or below the `#define`
lines (e.g., reference BOARD_NAME and MANUFACTURER_ID) so the target contains
required maintainer metadata.
|
|
||
| #define USE_ACC | ||
| #define USE_GYRO | ||
| #define USE_ACCGYRO_BMI270 |
There was a problem hiding this comment.
New targets with BMI270 not accepted
| #define MOTOR6_PIN PB0 | ||
| #define MOTOR7_PIN PD12 | ||
| #define MOTOR8_PIN PD13 | ||
| #define LED_STRIP_PIN PD14 |
There was a problem hiding this comment.
Timer conflicts with M7 and M8
There was a problem hiding this comment.
We could remove M5-M8 and add AIO suffix.
This target does not comply with Betaflight Manufacturer Design Guidelines:
Reference: https://micoair.com/flightcontroller_micoair743v2_aio_45a/
Summary by CodeRabbit