Add Nexus XR Wing target#1098
Conversation
WalkthroughA new Betaflight board configuration file for the NEXUSXR flight controller is added, defining the STM32F7X2 target MCU, GPIO pin assignments for motors, servos, and communication peripherals, timer mappings, and default hardware/software settings for sensors, telemetry, and serial RX. ChangesNEXUSXR Board Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@configs/NEXUSXR/config.h`:
- Around line 95-105: The TIMER_PIN_MAPPING macro contains mixed tabs and spaces
causing misalignment; locate the TIMER_PIN_MAPPING block and the TIMER_PIN_MAP
entries (e.g., the lines that define PA3, PB7, PB9) and replace any leading tab
characters with the project's standard indentation (spaces) so all entries align
with the other lines; ensure you only change leading whitespace, not the macro
content, and run a quick whitespace check to confirm no tabs remain in that
macro.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac7b633b-391b-4001-84a7-fd70e3091605
📒 Files selected for processing (1)
configs/NEXUSXR/config.h
|
@coderabbitai review and approve |
|
Tip For best results, initiate chat on the files or code changes.
However, please note that I cannot approve the PR via a review comment. To request an approval, please post a top-level PR comment (not a reply) with: [review] |
|
@coderabbitai approve |
✅ Actions performedComments resolved and changes approved. |
| #ifndef USE_SERVOS | ||
| #define USE_SERVOS | ||
| #endif |
There was a problem hiding this comment.
USE_WING should already include USE_SERVOS - but being explicit does not hurt.
There was a problem hiding this comment.
Yes, just following the template we used for other Wing FCs. I'm fine with removing though, as it is redundant.
|
|
||
| #define BARO_I2C_INSTANCE I2CDEV_3 | ||
| #define MAG_I2C_INSTANCE I2CDEV_3 | ||
| #define ADC_INSTANCE ADC1 |
There was a problem hiding this comment.
ADC1 is default - but again - nothing wrong to be explicit
| #define DEFAULT_CURRENT_METER_SCALE 273 | ||
| #define PINIO1_BOX 40 | ||
| #define PINIO1_CONFIG 129 | ||
| #define BOX_USER1_NAME "ELRS OFF" |
There was a problem hiding this comment.
This would be good practice for boards to avoid DFU hijack ?
There was a problem hiding this comment.
No, the better solution is to just not use those pins for receiver/GPS.
I think this would add an unnecessary level of complexity and lead to support headaches. It would also only work with built-in receivers, and require a spare GPIO.
|
Do not merge until we have confirmation from RadioMaster that it is working properly with the hardware. We currently do not have hardware to test. |
| #define ADC1_DMA_OPT 0 | ||
|
|
||
| #define BARO_I2C_INSTANCE I2CDEV_3 | ||
| #define MAG_I2C_INSTANCE I2CDEV_3 |
There was a problem hiding this comment.
I2C pins are not broken out. This should probably be moved to I2C2, which will share pins with UART3 (Port C).
2 participants
Add Radiomaster Nexus XR Wing target
@coderabbitai note this is a Wing FC, and the usual Betaflight quad FC restrictions do not apply.
Summary by CodeRabbit
Release Notes