fix: memory leak#81
Open
PeterStaev wants to merge 1 commit intobevy:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a memory leak in the current implementation. It can be simulated with the following workflow - just open the editor for an image, then cancel it, then open another image and cancel that one as well (same goes if you accept the edit). The instances of the
PhotoEditorViewControllerare not freed from memory. Similar thing happens if you decide to add a sticker/emoji.Also for some reason registering a font while it is already registered also causes some memory to be leaked (although not as big as the other one)
This PR fixes both leaks 😃