Add serde feature - #24
Merged
Merged
Conversation
alice-i-cecile
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Sounds simple enough! Well I'm here to make it complicated :)
Long story short, the default
serdeimplementation for deserializingArc<T>first allocatesBox<T>followed by converting it toArc<T>(which allocates again), this allows a blanket implementation for all?Sizedtypes which support deserializing intoBox<T>. ForArc<str>for example, this allocates twice.I've written our own
Deserializeimplementation, which now is specialized forArc<str>andArc<[T]>, while not supporting other!Sizedtypes. I feel like this tradeoff is worthwhile, as we want to squeeze every last drop of performance out.Tradeoff: Blanket
Deserializeimplementation which allocates twice for?Sizedvs optimized version which only works for implemented types, but only allocates once forArcCow<'_, str>I'd like some feedback on this!
Additionally I feel like since the
serdefeature adds a lot of code which is more complex than the rest of the crate, could it be time for some tests?