Resources section for new book#296
Resources section for new book#296alice-i-cecile wants to merge 7 commits intobevyengine:new-bookfrom
Conversation
Co-authored-by: James Liu <contact@jamessliu.com>
alice-i-cecile
force-pushed
the
ecs-resources
branch
from
8973ae7 to
34aad52
Compare
| .insert_resource(InputMode::Recording) | ||
| .add_system(record_secret) | ||
| // The system ordering here ensures that we don't spy on the input before it's entered | ||
| .add_system(check_secret.before(check_secret)) |
There was a problem hiding this comment.
Is this line correct? (I don't know Bevy but to me adding a system before itself seems like it doesn't make sense)
There was a problem hiding this comment.
Nope, this is a typo :)
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
Tiny nitpick, otherwise I like it overall. Once the typo in the check_secret example is fixed this could probably be merged with the new-book and iterate when necessary.
| } | ||
| ``` | ||
|
|
||
| In rare cases, you may need to add a resource after app startup. |
There was a problem hiding this comment.
I think I would extract that entire paragraph to it's own section, at least to make it easier to link to it.
| rather than being automatically scheduled to the first available thread. | ||
| This can negatively impact system-level parallelism: systems with any nonsend parameters are always incompatible with each other as they both need to run on the main thread. | ||
|
|
||
| [`Send + Sync`]: https://doc.rust-lang.org/nomicon/send-and-sync.html No newline at end of file |
There was a problem hiding this comment.
I'm pretty sure markdownlint is only failing because this is missing a new line at the end of the file. I believe you can configure vscode to do that automatically.
|
Closing as we will very likely start new PRs (and use this as a reference) when we pick up the new book effort again. |
5 participants
Ported from #182.
Status