Don't trigger animation events when paused#15677
Merged
mockersf merged 2 commits intobevyengine:mainfrom Oct 6, 2024
Merged
Conversation
alice-i-cecile
approved these changes
Oct 6, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I think this would be clearer with an && !paused style, but I won't block on that.
alice-i-cecile
added
C-Bug
Contributor
Author
That's unstable for |
Member
|
Curse you unstable Rust features. Mild preference for nesting. |
mweatherley
approved these changes
Oct 6, 2024
mweatherley
added
S-Ready-For-Final-Review
mockersf
approved these changes
Oct 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2024
# Objective I completely forgot that animation events are triggered in two separate systems (sorry). The issue ~~fixed~~ by #15677, can still happen if the animation event is not targeting a specific bone. ## Solution _Realy_ don't trigger animation events for paused animations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Pausing the
animated_foxexample perfectly as one of the feet hits the ground causes the event to be triggered every frame.Context: #15538
Solution
Don't trigger animation events if the animation is paused.
Testing
Ran the example, I no longer see the issue.