Default button material behavior#1857
Closed
oldstork wants to merge 2 commits intobevyengine:mainfrom
oldstork:button-default-behavior
Closed
Default button material behavior#1857oldstork wants to merge 2 commits intobevyengine:mainfrom oldstork:button-default-behavior
oldstork wants to merge 2 commits intobevyengine:mainfrom
oldstork:button-default-behavior
Conversation
added 2 commits
April 8, 2021 12:44
alice-i-cecile
added
A-UI
Member
|
Welcome! This is a nice little change :) UI is currently slated for a complete overhaul for 0.6 (see #254); come hang out in Discord and on the pending RFC repo (#1662) if you'd like to be part of that process. This PR is likely to sit in limbo until that's resolved, but it would be nice to rebase this once that's done <3 |
cart
added
the
S-Pre-Relicense
mockersf
removed
the
S-Pre-Relicense
Member
|
Coming back to this, I think it's probably a bit too opinionated for a base button type. Closing this out, we can revisit it once we have a better idea of the widget design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a simple, customizable, and overridable default material behavior for buttons. Relevant examples are updated.
First time contributor here--I opened this PR because this is a behavior that I personally thought I would like when using Bevy. Feedback (even if negative--but hopefully not) is appreciated.