Skip to content

Conversation

@IceSentry
Copy link
Contributor

Objective

  • FullscreenMaterial bind groups can be created ahead of time instead of creating them in the encoding system

Solution

  • Create the bind groups in a prepare system

Testing

  • I ran the example and it worked

@IceSentry IceSentry added the A-Rendering Drawing game state to the screen label Feb 10, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering (2026 Proposal) Feb 10, 2026
@IceSentry IceSentry added S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Code-Quality A section of code that is hard to understand or change labels Feb 10, 2026
Copy link
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as there's no problem with texture ID reuse.

@github-actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22886

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

Copy link
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be done in a generic place for any kind of post-processing system to use.

@IceSentry
Copy link
Contributor Author

The issue is it also binds other things that are FullscreenMaterial specific so it's hard to generalize easily

@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: No status
Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

3 participants