(WinitPlugin) Allow control of game tick#2872
Closed
xiaopengli89 wants to merge 5 commits intobevyengine:mainfrom
Closed
(WinitPlugin) Allow control of game tick#2872xiaopengli89 wants to merge 5 commits intobevyengine:mainfrom
xiaopengli89 wants to merge 5 commits intobevyengine:mainfrom
Conversation
ca6cff9 to
4928e42
Compare
409bf67 to
725a43e
Compare
Member
|
@aevyrie is this still needed? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Related to #1343, this PR allow dynamic control of game tick, and benefit power savings for GUI applications.
Solution
To disable the default poll game tick, insert
WinitTick::new(false)resource into the world, animation systems can callpoll_tickwithWinitTickresource to poll game tick for the next frame.The default
default_poll_tickparameter value ofWinitTickistrueto prevent break changes.Todo
Assetis loaded asynchronously, we should send a tick event toEventLoop.