Hide UnsafeWorldCell::unsafe_world#9741
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Oct 2, 2023
Merged
Conversation
alice-i-cecile
added
A-ECS
james7132
approved these changes
Sep 19, 2023
alice-i-cecile
approved these changes
Oct 2, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective We've done a lot of work to remove the pattern of a `&World` with interior mutability (bevyengine#6404, bevyengine#8833). However, this pattern still persists within `bevy_ecs` via the `unsafe_world` method. ## Solution * Make `unsafe_world` private. Adjust any callsites to use `UnsafeWorldCell` for interior mutability. * Add `UnsafeWorldCell::removed_components`, since it is always safe to access the removed components collection through `UnsafeWorldCell`. ## Future Work Remove/hide `UnsafeWorldCell::world_metadata`, once we have provided safe ways of accessing all world metadata. --- ## Changelog + Added `UnsafeWorldCell::removed_components`, which provides read-only access to a world's collection of removed components.
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective We've done a lot of work to remove the pattern of a `&World` with interior mutability (bevyengine#6404, bevyengine#8833). However, this pattern still persists within `bevy_ecs` via the `unsafe_world` method. ## Solution * Make `unsafe_world` private. Adjust any callsites to use `UnsafeWorldCell` for interior mutability. * Add `UnsafeWorldCell::removed_components`, since it is always safe to access the removed components collection through `UnsafeWorldCell`. ## Future Work Remove/hide `UnsafeWorldCell::world_metadata`, once we have provided safe ways of accessing all world metadata. --- ## Changelog + Added `UnsafeWorldCell::removed_components`, which provides read-only access to a world's collection of removed components.
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective We've done a lot of work to remove the pattern of a `&World` with interior mutability (bevyengine#6404, bevyengine#8833). However, this pattern still persists within `bevy_ecs` via the `unsafe_world` method. ## Solution * Make `unsafe_world` private. Adjust any callsites to use `UnsafeWorldCell` for interior mutability. * Add `UnsafeWorldCell::removed_components`, since it is always safe to access the removed components collection through `UnsafeWorldCell`. ## Future Work Remove/hide `UnsafeWorldCell::world_metadata`, once we have provided safe ways of accessing all world metadata. --- ## Changelog + Added `UnsafeWorldCell::removed_components`, which provides read-only access to a world's collection of removed components.
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective We've done a lot of work to remove the pattern of a `&World` with interior mutability (bevyengine#6404, bevyengine#8833). However, this pattern still persists within `bevy_ecs` via the `unsafe_world` method. ## Solution * Make `unsafe_world` private. Adjust any callsites to use `UnsafeWorldCell` for interior mutability. * Add `UnsafeWorldCell::removed_components`, since it is always safe to access the removed components collection through `UnsafeWorldCell`. ## Future Work Remove/hide `UnsafeWorldCell::world_metadata`, once we have provided safe ways of accessing all world metadata. --- ## Changelog + Added `UnsafeWorldCell::removed_components`, which provides read-only access to a world's collection of removed components.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective We've done a lot of work to remove the pattern of a `&World` with interior mutability (bevyengine#6404, bevyengine#8833). However, this pattern still persists within `bevy_ecs` via the `unsafe_world` method. ## Solution * Make `unsafe_world` private. Adjust any callsites to use `UnsafeWorldCell` for interior mutability. * Add `UnsafeWorldCell::removed_components`, since it is always safe to access the removed components collection through `UnsafeWorldCell`. ## Future Work Remove/hide `UnsafeWorldCell::world_metadata`, once we have provided safe ways of accessing all world metadata. --- ## Changelog + Added `UnsafeWorldCell::removed_components`, which provides read-only access to a world's collection of removed components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
We've done a lot of work to remove the pattern of a
&Worldwith interior mutability (#6404, #8833). However, this pattern still persists withinbevy_ecsvia theunsafe_worldmethod.Solution
unsafe_worldprivate. Adjust any callsites to useUnsafeWorldCellfor interior mutability.UnsafeWorldCell::removed_components, since it is always safe to access the removed components collection throughUnsafeWorldCell.Future Work
Remove/hide
UnsafeWorldCell::world_metadata, once we have provided safe ways of accessing all world metadata.Changelog
UnsafeWorldCell::removed_components, which provides read-only access to a world's collection of removed components.