fix(restore): a member server's own restore is not a test attempt - #486
Merged
Conversation
passcod
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Upgrades page showed Pakistan's planned row with an orange "no report" chip, implying the test pipeline ran and got stuck. No test had run. The chip pairs restore credential issuances against verification reports, and the unpaired issuances it found were the Pakistan clone servers refreshing themselves: member servers restore for their own purposes and never report, so any group whose servers do this lights the chip whenever it has an open plan.
attempt_statenow excludes issuances from devices belonging to the group's live servers, the same member-device filter the restore-activity view already applies. The spec's verdicts section already defers to that derivation ("exactly as restore-health reporting already derives"), so this brings the chip in line with the spec; restore-health reporting gains a sentence making the consumers-only scope explicit.Chose a blocklist of member devices over an allowlist of declared consumers deliberately: a consumer whose declaration is deleted mid-run should still surface as ended-without-report rather than vanish.