add details for tested devices to README#1
Open
seriousManual wants to merge 1 commit intobeyondscreen:masterfrom
Open
add details for tested devices to README#1seriousManual wants to merge 1 commit intobeyondscreen:masterfrom
seriousManual wants to merge 1 commit intobeyondscreen:masterfrom
Conversation
Member
|
@seriousManual you tested this with both the MK2 and the USB DMX Pro? |
Member
|
I just tested this with the MK2 and it's working. Need to verify the USB DMX Pro too. |
Author
|
I tested it with the USB DMX Pro (https://www.thomann.de/de/enttec_dmx_usb_pro_interface.htm). |
TimPietrusky
requested changes
Dec 7, 2018
Member
TimPietrusky
left a comment
TimPietrusky
left a comment
There was a problem hiding this comment.
I have some changes regarding the correct name of the family (which should be DMX USB PRO) and the name of the manufacturer (they write themselves like this on their website: ENTTEC)
| @@ -1,6 +1,10 @@ | |||
| # fivetwelve driver for ENTTEC USB PRO mk2 | |||
| # fivetwelve driver for the USB PRO family by enttec | |||
Member
There was a problem hiding this comment.
I would say "the DMX USB PRO family by ENTTEC", because that is what you would search for.
| # fivetwelve driver for the USB PRO family by enttec | ||
|
|
||
| This is a [fivetwelve][] driver for the [USB PRO mk2][usbpromk2] DMX-interface made by enttec. | ||
| This is a [fivetwelve][] driver for the USBPRO DMX-interface family made by enttec. |
Member
There was a problem hiding this comment.
Also the same for this: "DMX USB PRO family made by ENTTEC".
| This is a [fivetwelve][] driver for the USBPRO DMX-interface family made by enttec. | ||
| From this line the following devices have been tested: | ||
|
|
||
| * [Enttec USB Pro][usbpro] |
| From this line the following devices have been tested: | ||
|
|
||
| * [Enttec USB Pro][usbpro] | ||
| * [Enttec USB Pro mk2][usbpromk2] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.