fix(ui): prevent autosave from reverting recently edited fields - #1
Closed
lucasvass1 wants to merge 1 commit into
Closed
fix(ui): prevent autosave from reverting recently edited fields#1lucasvass1 wants to merge 1 commit into
lucasvass1 wants to merge 1 commit into
Conversation
… remounting relationship/upload list drawers Switching to a different field while a previous autosave request was still in flight cleared that field's modified protection, so a stale response could overwrite the newer local edit. Track a per-field last-modified timestamp and compare it against when each request was sent, so a response is only accepted if no local edit happened after it was dispatched. Also preserve the value/initialValue reference for unmodified fields when the incoming server value is content-identical, since object/array-shaped values (e.g. relationship and upload fields) otherwise get a new reference on every autosave merge, causing their list drawers to needlessly recompute filter options and remount.
|
@lucasvass1 is attempting to deploy a commit to the Beyond Communication Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Opened this by mistake against this reproduction repo instead of the actual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes payloadcms#17676
Summary
modifiedAttimestamp and comparing it against when each request was sent — a response is only accepted for a field if no local edit happened to it after that specific request was dispatched.useListDrawerrecomputing and remounting the open drawer. Fixed by preserving the existing reference inmergeServerFormStatewhen the incoming value is deeply equal to the current one.Test plan
mergeServerFormStatecovering reference preservation for content-identical valuestest/form-statestill pass (no regression to the "don't overwrite a field being actively edited" behavior)pnpm run build:coreand lint pass