Selected Unit Tests for BIBFRAME Monograph and Serials Works and Instances - #47
Merged
Conversation
jermnelson
requested review from
kallimathios,
katnai1,
kirkhess,
melanieWacker,
mixterj,
ntra00 and
sfolsom
January 29, 2026 21:43
kallimathios
approved these changes
Jan 29, 2026
jermnelson
force-pushed
the
t46-unit-tests
branch
from
January 30, 2026 17:24
9efc808 to
17351ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
Uses Library of Congress test records to test the following DCTap TSV files:
Still need example records to test the following DCTap TSV files:
Currently all of the examples are passing validation with no warnings or violations. We should add example RDFs that fail validation with a mixture of SHACL Warnings and Violations.The SHACL validation call in the tests were incorrect, all of the example RDFs have violations and warnings reflected in the parameters.
NOTE: Also adds Github Action for running tests when a Pull Request is created.