fix: Windows async mode and Chinese encoding (#127)#129
Merged
bfly123 merged 1 commit intobfly123:mainfrom Mar 11, 2026
Merged
Conversation
…pt (bfly123#127) The Windows PowerShell background script was missing CCB_RUN_DIR env var (causing async mode to fail) and proper UTF-8 encoding setup (causing Chinese character garbling). Also adds CCB_EMAIL_* env var forwarding for email caller parity with Unix.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #127 — Windows async mode (
ask codex "message") fails silently and Chinese characters display as garbled text.Root causes:
CCB_RUN_DIRenv var, so the async task couldn't locate the askd daemon state file[Console]::OutputEncodingwas set, missing$OutputEncoding,[Console]::InputEncoding, and$env:PYTHONIOENCODINGCCB_EMAIL_*env vars were not forwarded to the background script (Unix had this, Windows didn't)Changes:
bin/ask: AddCCB_RUN_DIR, full UTF-8 encoding, andCCB_EMAIL_*to Windows PowerShell script — achieving parity with Unixtest/test_windows_compat.py: 10 new tests verifying Windows/Unix feature parityTest plan
pytest test/test_windows_compat.py -v— 10 passedask codex "test message"on Windows (async mode)ask codex "中文测试"on Windows (Chinese encoding)