fix: _NoopThread._started overwrites Thread._started (#130)#131
Closed
LeoLin990405 wants to merge 1 commit intobfly123:mainfrom
Closed
fix: _NoopThread._started overwrites Thread._started (#130)#131LeoLin990405 wants to merge 1 commit intobfly123:mainfrom
LeoLin990405 wants to merge 1 commit intobfly123:mainfrom
Conversation
…fly123#130) _NoopThread used self._started (a list) which overwrites threading.Thread._started (an Event), breaking is_alive() calls. Renamed to self.started_keys and made the thread actually start/stay alive so PerSessionWorkerPool.get_or_create() can correctly detect live workers.
Owner
|
有冲突 |
Contributor
Author
|
Closing this PR — the fix has already been applied on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #130 —
test_per_session_worker_pool_reuses_same_keyfails on all 10 CI jobs (every platform × every Python version).Root cause
_NoopThreadintest/test_worker_pool.pyusedself._started(alist) as an attribute, which overwritesthreading.Thread._started(an internalthreading.Event). WhenPerSessionWorkerPool.get_or_create()callsworker.is_alive(), it triggersself._started.is_set()on alist→AttributeError.Changes
self._started→self.started_keysto avoid collision withThread._startedsuper().start()call so the thread actually starts andis_alive()returnsTruerun()withEvent.wait()to keep the thread alive during the teststop()+join()) at the end of the testTest-only change — zero impact on production code.
Test plan
pytest test/test_worker_pool.py -v— 3 passed (previously 1 failed, 2 passed)