Open
Conversation
* Fix for no stdint.h support before msvc 10. * Fix some syntax errors and logic errors to get codes work with msvc. * Kill all warnings of compiling with msvc.
Fix the wrong characters count of TCHAR string, that produce unnecessary characters at the end of result, might result in wrong result of comparing std::string(s).
The top-level collections were divided into different physical device object (PDO) in Windows (see: http://msdn.microsoft.com/en-us/library/windows/hardware/ff543475(v=vs.85).aspx). Therefore, there is only one top-level collection, others are sub-collections (see: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542355(v=vs.85).aspx#ddk_link_collection_array_kg).
The device_type::read() would not return while there is no any input, even the device was been closed. It's necessary to add an invalid handle checking before invoking ReadFile to prevent an endless loop.
An usage range is specified by usage minimum and usage maximum items in report descriptor, this range is start from usage minimum and end with usage maximum, but includes usage minimum and usage maximum as well.
Should use overload style WriteFile, and use bufferOutputReport() instead of bufferInputReport()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull this branch you'll get some bugs fixed and support Visual Studio, following is a list of changes: