Skip to content

[MAINT] Apply pre-commit fixes and clean up Ruff issues - #1269

Open
mcsitter wants to merge 4 commits into
bids-standard:mainfrom
mcsitter:chore/pre-commit-fixes
Open

[MAINT] Apply pre-commit fixes and clean up Ruff issues#1269
mcsitter wants to merge 4 commits into
bids-standard:mainfrom
mcsitter:chore/pre-commit-fixes

Conversation

@mcsitter

@mcsitter mcsitter commented Aug 7, 2026

Copy link
Copy Markdown

Summary

I want to contribute type hints to make progress on #1130. Since adding a type checker and thus introducing new tooling, I first wanted to resolve the current issues reported by the existing tooling.

This PR applies the pre-commit fixes and resolves the current Ruff issues so the repository starts from a clean baseline.

Validation

  • tox run -e full
  • tox run -e docs
  • tox run -e noqa-budget
  • pre-commit run --all-files

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.63%. Comparing base (3565eb5) to head (7e0b905).

Files with missing lines Patch % Lines
src/bids/utils.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   89.63%   89.63%   -0.01%     
==========================================
  Files          71       71              
  Lines        8036     8035       -1     
  Branches      977      977              
==========================================
- Hits         7203     7202       -1     
  Misses        591      591              
  Partials      242      242              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcsitter

mcsitter commented Aug 8, 2026

Copy link
Copy Markdown
Author

I already have the return types for all public functions typed out. The work is on this branch.

If you’d prefer the type annotations to be included in this PR rather than a separate follow-up, I can update the PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant