[MAINT] Apply pre-commit fixes and clean up Ruff issues - #1269
Open
mcsitter wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
- Coverage 89.63% 89.63% -0.01%
==========================================
Files 71 71
Lines 8036 8035 -1
Branches 977 977
==========================================
- Hits 7203 7202 -1
Misses 591 591
Partials 242 242 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
I already have the return types for all public functions typed out. The work is on this branch. If you’d prefer the type annotations to be included in this PR rather than a separate follow-up, I can update the PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I want to contribute type hints to make progress on #1130. Since adding a type checker and thus introducing new tooling, I first wanted to resolve the current issues reported by the existing tooling.
This PR applies the pre-commit fixes and resolves the current Ruff issues so the repository starts from a clean baseline.
Validation
tox run -e fulltox run -e docstox run -e noqa-budgetpre-commit run --all-files