feat: remove MSstats post-processing step from quantms#701
feat: remove MSstats post-processing step from quantms#701ypriverol wants to merge 12 commits intobigbio:devfrom
Conversation
…json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…step Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
Removes the in-pipeline MSstats post-processing steps (R-based MSstats/MSstatsTMT execution) while keeping generation of MSstats-compatible input tables (*_msstats_in.csv) for downstream, user-run MSstats analysis.
Changes:
- Removed
MSSTATS_LFQ/MSSTATS_TMTmodules and their invocation from LFQ/TMT/DIA workflows. - Removed MSstats post-processing parameters from
nextflow.configandnextflow_schema.json, plus the dedicatedmsstats/publishDir. - Updated output documentation and test configs to reflect that MSstats is no longer run inside the pipeline.
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/tmt.nf | Drops MSSTATS_TMT step and stops emitting msstats_out. |
| workflows/lfq.nf | Drops MSSTATS_LFQ step and stops emitting msstats_out. |
| workflows/dia.nf | Drops MSSTATS_LFQ post-step and stops emitting msstats_out. |
| nextflow_schema.json | Removes MSstats post-processing parameter group and schema reference. |
| nextflow.config | Removes MSstats post-processing params defaults. |
| conf/modules/shared.config | Removes msstats/ publishDir block for MSstats post-processing outputs. |
| conf/tests/test_localize.config | Removes skip_post_msstats test param. |
| conf/tests/test_latest_dia.config | Removes skip_post_msstats test param. |
| conf/tests/test_dia_dotd.config | Removes skip_post_msstats test param. |
| conf/tests/test_dia.config | Removes skip_post_msstats test param. |
| docs/output.md | Updates output structure/docs to state MSstats is run externally. |
| modules/local/msstats/msstats_tmt/meta.yml | Deleted MSstatsTMT module metadata. |
| modules/local/msstats/msstats_tmt/main.nf | Deleted MSstatsTMT Nextflow process. |
| modules/local/msstats/msstats_lfq/meta.yml | Deleted MSstats LFQ module metadata. |
| modules/local/msstats/msstats_lfq/main.nf | Deleted MSstats LFQ Nextflow process. |
| bin/msstats_utils.R | Deleted shared MSstats R helper script. |
| bin/msstats_tmt.R | Deleted MSstatsTMT R runner script. |
| bin/msstats_plfq.R | Deleted MSstats LFQ R runner script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix filename pattern: msstats_in.csv -> *_msstats_in.csv (prefix is workflow-dependent) - Fix file type: TSV -> CSV (actual output is comma-separated) - Rename misleading "MSstats-processed mzTab" heading to "MSstats post-processing (external)" - Limit DDA pipelines to LFQ and ISO (DIA removed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Accept deletion of DIA files (dia.nf, test_dia*.config) merged via PR bigbio#702 - shared.config: remove MSSTATS_LFQ|MSSTATS_TMT publishDir block (our change) and FINAL_QUANTIFICATION|DIANN_MSSTATS from quant_tables pattern (from dev) - nextflow_schema.json: remove both DIA-NN and statistical_post_processing $defs blocks and their allOf $refs (each PR removed one; merged = remove both) - docs/output.md: remove DIA output structure sections (from dev) and MSstats-processed results entry (our change); keep improved MSstats description with correct filename pattern and CSV type Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
MSSTATS_LFQandMSSTATS_TMTmodules and their R scripts (bin/msstats_plfq.R,bin/msstats_tmt.R,bin/msstats_utils.R) from the pipelinenextflow.configandnextflow_schema.json(skip_post_msstats, ref_condition, contrasts, msstats_* params)conf/modules/shared.configMSSTATS_CONVERTER(OpenMS) andDIANN_MSSTATSso quantms still producesmsstats_in.csvas input for downstream MSstats analysisMotivation
MSstats post-processing is interactive and exploratory. Embedding it in the automated pipeline creates unnecessary complexity — users need to re-run with different contrasts or parameters. quantms should produce the MSstats-compatible input files and stop there, leaving statistical analysis to the user.
Closes #697 (if applicable)
Test plan
test_lfqprofile: verifyquant_tables/msstats_in.csvis still producedtest_tmtprofile: verifyquant_tables/out_msstats_in.csvis still producedtest_diaprofile: verifymsstats_in.csvis still producedmsstats/output directory is no longer created🤖 Generated with Claude Code