TRAC-965: Return DNS pointing records on domain add - #3156
Open
jordanarldt wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: edc4cc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
jordanarldt
marked this pull request as ready for review
July 31, 2026 15:58
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The Domains API now returns
pointing_recordson create — the A and CNAME values a merchant publishes to point their domain at the project.catalyst domains addprints them with the success message instead of ending at "Domain added":Two things worth a look:
createdDomainSchemarather thandomainSchema—getDomain/listDomains/findDomainkeep returningDomainand can't surface a field the API doesn't send.--waitre-fetches the domain resource, which doesn't carry the records, so the block is formatted from the create response before polling reassignsresult. A test pins this.Every field is optional: the API sends
pointing_records: nulluntil the domain is bound and nulls individual values it doesn't have, so a missing row is omitted and the DNS output is skipped entirely when there's nothing publishable.Testing
npm run test,npm run typecheck, andnpm run lintinpackages/catalyst— green (609 tests). New cases cover the formatter,createDomainparsing (records present and null), andaddoutput including after--wait.Manual:
catalyst domains add <subdomain>.<your-domain>against a store with the Domains API enabled.Migration
None.