Skip to content

TRAC-965: Return DNS pointing records on domain add - #3156

Open
jordanarldt wants to merge 1 commit into
canaryfrom
TRAC-965
Open

TRAC-965: Return DNS pointing records on domain add#3156
jordanarldt wants to merge 1 commit into
canaryfrom
TRAC-965

Conversation

@jordanarldt

@jordanarldt jordanarldt commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What/Why?

The Domains API now returns pointing_records on create — the A and CNAME values a merchant publishes to point their domain at the project. catalyst domains add prints them with the success message instead of ending at "Domain added":

✔ Domain www.example.com added.
www.example.com pending
ℹ Point www.example.com at this project with one of these DNS records:
  A      198.51.100.10
  CNAME  shared.hosting.bigcommerce.com
ℹ Use the CNAME for a subdomain, or the A record for an apex domain. Save them now — only `domains add` returns them.
ℹ Run `catalyst domains status www.example.com` to check verification progress.

Two things worth a look:

  • Only the create endpoint returns the records, so they live on createdDomainSchema rather than domainSchemagetDomain/listDomains/findDomain keep returning Domain and can't surface a field the API doesn't send.
  • --wait re-fetches the domain resource, which doesn't carry the records, so the block is formatted from the create response before polling reassigns result. A test pins this.

Every field is optional: the API sends pointing_records: null until the domain is bound and nulls individual values it doesn't have, so a missing row is omitted and the DNS output is skipped entirely when there's nothing publishable.

Testing

image

npm run test, npm run typecheck, and npm run lint in packages/catalyst — green (609 tests). New cases cover the formatter, createDomain parsing (records present and null), and add output including after --wait.

Manual: catalyst domains add <subdomain>.<your-domain> against a store with the Domains API enabled.

Migration

None.

@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: edc4cc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview Jul 31, 2026 4:04pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Report

Comparing against baseline from 7a0cdc1 (2026-07-31).

No bundle size changes detected.

@jordanarldt
jordanarldt marked this pull request as ready for review July 31, 2026 15:58
@jordanarldt
jordanarldt requested a review from a team as a code owner July 31, 2026 15:58
@github-actions

Copy link
Copy Markdown
Contributor

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 89 92 91 95

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 77 68 69 92
Accessibility 95 95 95 98
Best Practices 100 100 100 100
SEO 88 88 88 100

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 3.3 s 6.2 s 5.9 s 3.3 s
CLS 0.04 0.19 0.039 0
FCP 1.2 s 1.2 s 1.2 s 1.2 s
TBT 0 ms 0 ms 0 ms 0 ms
Max Potential FID 40 ms 30 ms 50 ms 40 ms
Time to Interactive 3.4 s 6.2 s 5.9 s 3.3 s

Full Unlighthouse report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant