Skip to content

fix(a11y): TRAC-251 updated accessibility features#2656

Merged
mfaris9 merged 5 commits into
masterfrom
TRAC-251
May 12, 2026
Merged

fix(a11y): TRAC-251 updated accessibility features#2656
mfaris9 merged 5 commits into
masterfrom
TRAC-251

Conversation

@mfaris9
Copy link
Copy Markdown
Contributor

@mfaris9 mfaris9 commented May 11, 2026

What?

Fix background and foreground colors contrast ratio. This ticket was old, and since then other lighthouse issues have popped up (see screenshot). I took the opportunity to fix these new issues to bring the lighthouse score to 100 (see screenhot).

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Screenshots

Screenshot 2026-05-08 at 4 30 35 PM Screenshot 2026-05-12 at 10 25 27 AM

@mfaris9 mfaris9 requested a review from a team as a code owner May 11, 2026 19:00
Comment thread templates/components/common/body.html Outdated
Comment thread assets/scss/layouts/footer/_footer.scss Outdated
Comment thread config.json Outdated
@bc-yevhenii-buliuk
Copy link
Copy Markdown
Contributor

bc-yevhenii-buliuk commented May 11, 2026

@mfaris9 not critical, but:

  1. try to follow the existing naming pattern fix(a11y) -> fix(storefront)
  2. use link to the Jira ticket (not Linear) if possible
  3. before merging the PR don't forget squash all commits into one
  4. CONTRIBUTING.md may be useful

…er), and update other 8F8F8F colors for contrast
Comment thread assets/scss/layouts/footer/_footer.scss Outdated
Copy link
Copy Markdown
Contributor

@bc-yevhenii-buliuk bc-yevhenii-buliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@mfaris9 mfaris9 merged commit 1012814 into master May 12, 2026
1 check passed
@mfaris9 mfaris9 deleted the TRAC-251 branch May 12, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants