Add support for Ruby 3.2#30
Open
j05h wants to merge 2 commits into
Open
Conversation
Upgrade omniauth and oauth2 gems.
j05h
commented
Sep 14, 2023
| # removed in 1.4.0: https://github.com/intridea/omniauth-oauth2/pull/70 | ||
| def callback_url | ||
| full_host + script_name + callback_path | ||
| full_host + callback_path |
Contributor
Author
There was a problem hiding this comment.
script_name is part of callback_path and so its redundant to have here.
j05h
commented
Sep 14, 2023
Comment on lines
+33
to
+34
| authorize_url: 'oauth2/authorize', | ||
| token_url: 'oauth2/token' |
Contributor
Author
There was a problem hiding this comment.
These are the default values in later versions of OmniAuth.
exeDog
reviewed
Sep 14, 2023
Comment on lines
+33
to
+34
| authorize_url: 'oauth2/authorize', | ||
| token_url: 'oauth2/token' |
Contributor
There was a problem hiding this comment.
wouldn't this be a breaking change?
Contributor
Author
There was a problem hiding this comment.
Should not be. This is the same change done in the upstream gem. I do think we need a PoL before merge though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Ruby 3.2 and upgrades omniauth and oauth2 gems.
Adds CircleCI builds