Skip to content

Fix hx-prompt Unicode header encoding#3846

Open
cyphercodes wants to merge 1 commit into
bigskysoftware:four-devfrom
cyphercodes:fix-hx-prompt-unicode-3841
Open

Fix hx-prompt Unicode header encoding#3846
cyphercodes wants to merge 1 commit into
bigskysoftware:four-devfrom
cyphercodes:fix-hx-prompt-unicode-3841

Conversation

@cyphercodes

Copy link
Copy Markdown

Description

URI-encodes the HX-Prompt header value set by the hx-prompt extension so Unicode prompt responses can be used with fetch without triggering the non ISO-8859-1 header-value error.

Corresponding issue: Fixes #3841

Testing

  • npx web-test-runner --files test/tests/ext/hx-prompt.js --browsers chromium --config test/web-test-runner.config.mjs --playwright --coverage=false
  • npm test

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (four-dev for this htmx 4 beta bugfix)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant