Update Architecture Workflow extension to v1.2.2#33
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aca03bd56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ARCH_DIR="$REPO_ROOT/.specify/memory" | ||
|
|
||
| declare -A FILES=( | ||
| [architecture-synthesis]="$ARCH_DIR/architecture.md" |
There was a problem hiding this comment.
Including architecture.md in the readiness validator makes the synthesis refresh circular: the command outlines render the five view files, run this validator, and only render ARCH_FILE after ready_gate: PASS. On a fresh install setup-arch.sh creates architecture.md from the placeholder template, so this entry causes ARCH_PLACEHOLDER_PRESENT and prevents the first synthesis from ever being written even when all five views are ready.
Useful? React with 👍 / 👎.
| printf '%s\n' "$section_id" | sed 's/-/ /g' | awk '{ | ||
| for (i = 1; i <= NF; i++) { | ||
| $i = toupper(substr($i, 1, 1)) substr($i, 2) | ||
| } | ||
There was a problem hiding this comment.
The Bash validator derives headings by replacing every hyphen with a space, but the shipped templates use punctuation/casing such as Anti-patterns, Cross-View Architecture Model, and Failure, Degradation, and Closure. In default Bash environments, ARCH_VALIDATOR_FILE --json therefore reports these valid sections as missing and blocks readiness; the PowerShell validator already has the explicit heading map this path needs.
Useful? React with 👍 / 👎.
| if (line ~ /^\|.*\|$/ && line !~ /NEEDS ARCH UPDATE|NEEDS REPO FACTS UPDATE/) { | ||
| found = 1 | ||
| exit |
There was a problem hiding this comment.
A required Markdown table with only its header and separator currently passes section_has_content, because the header row matches this branch before any data row is required. If a command removes placeholder markers but leaves sections such as Source Traceability or Dependency Matrix with no records, the validator can still return ready_gate: PASS and allow synthesis from empty required sections.
Useful? React with 👍 / 👎.
1 participant
Summary
What changed
extensions/archsnapshot from the source release, including full-workflow commands and readiness validators.Validation
Community Source Contract: success onmainfor57ab4b4799054f23be3f9a2231059e744cf6dc62Extension Release Artifact: success for tagv1.2.2C:\Program Files\Git\bin\bash.exe tests/repository-first-contract.shfromextensions/archuv run python scripts/community/validate_integration.py --repo-root . --branch community/arch-v1.2.2 --pr-body-file %TEMP%\spec-kit-arch-v1.2.2-pr-body.mduv run pytest tests/test_arch_templates.py tests/test_setup_arch.py tests/test_extensions.py::TestExtensionManifest::test_bundled_default_catalogs_match_manifest tests/test_presets.py -q -k "community_smoke or smoke or workflow_preset or bundled_default_catalogs_match_manifest or arch"uv run pytest tests/integrations/test_cli.py -q -k "community_extensions_and_workflow_preset or community"git diff --check