Skip to content

Bugfix/get rank fix#76

Open
Jackywathy wants to merge 2 commits intobilly-yoyo:masterfrom
Jackywathy:bugfix/get_rank_fix
Open

Bugfix/get rank fix#76
Jackywathy wants to merge 2 commits intobilly-yoyo:masterfrom
Jackywathy:bugfix/get_rank_fix

Conversation

@Jackywathy
Copy link
Contributor

@Jackywathy Jackywathy commented Jan 9, 2021

fixes the problems with getting rank as per #75. Closes #75

- Rank.rank is now (correctly) the string name of the rank. Access the raw rank object via `rank_obj`. This is for compatibility with previous API.
- added a way to index into the ranked collection, handling the case were the rank was unranked
- added old ranking bands to pre ember rise seasons
- small tweaks to readability to rankinfo objects when printed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: rank is always unranked

1 participant