Skip to content

Visinfo guid is set to non required#24

Merged
BalintBende merged 6 commits intodevelopfrom
feature/SMN-2210_visinfo_guid_non_required
Mar 13, 2025
Merged

Visinfo guid is set to non required#24
BalintBende merged 6 commits intodevelopfrom
feature/SMN-2210_visinfo_guid_non_required

Conversation

@BalintBende
Copy link
Contributor

@BalintBende BalintBende commented Mar 13, 2025

Pull Request Template

Description

Fixes

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • CI/Build related changes (so that Github is happy)
  • Dockerfile related changes
  • Documentation content changes
  • Tests (extended coverage or fixing existing tests)
  • Updated dependencies

API Changes

  • Introducing a new method or property
  • Updating the API
  • Deprecating methods or properties

Environment (Docker)

  • Adding a new environment variable
  • Updating the production container

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my code in the local docker-compose environment
  • My feature branch builds on Github

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 7867f1c. ± Comparison against base commit 3a87ef2.

♻️ This comment has been updated with latest results.

@DanielLepold
Copy link
Contributor

Nice work, pls see my comments above

@BalintBende BalintBende merged commit 073b86b into develop Mar 13, 2025
3 checks passed
@BalintBende BalintBende deleted the feature/SMN-2210_visinfo_guid_non_required branch March 13, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants