fix(digest): count only newly appeared activities in daily digest#58
Merged
Conversation
Activities that linger in the Strava feed for several days were re-counted in every daily digest. build_digest_payload now accepts previous_entries (run-history entries from before the digest window) and excludes activity IDs already reported by an earlier digest from the total/given/would_give counts. Legacy history entries without ID lists keep their raw counts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Die tägliche Zusammenfassung dedupliziert Aktivitäten nur innerhalb des aktuellen Digest-Zeitraums. Eine Aktivität, die mehrere Tage im Strava-Feed bleibt, wurde daher in jeder täglichen Zusammenfassung erneut mitgezählt.
Lösung
build_digest_payloadakzeptiert jetztprevious_entries— Run-History-Einträge von vor dem Digest-Zeitfenster (also bereits von früheren Zusammenfassungen abgedeckt).total,given,would_give) ausgeschlossen. Jede Zusammenfassung zählt somit nur neu hinzugekommene Aktivitäten.app.pyteilt die History am Zeitstempel der letzten Zusammenfassung und übergibt beide Teile.previous_entriesist das Verhalten unverändert.Tests
6 neue Unit-Tests in
tests/unit/test_notify.py(Ausschluss je Zähler, Default-Verhalten, Legacy-Einträge in beiden Richtungen).Quality Gate: ruff check ✅ · ruff format ✅ · mypy ✅ · pytest 503 passed, Coverage 88 % ✅
🤖 Generated with Claude Code