Conversation
The v0.2.0 release cut a tag and GitHub Release with no GHCR image to show for it: publish.yml's `on: push: tags:` trigger never fired, because GitHub Actions doesn't let a ref created via the default GITHUB_TOKEN (which is how release-please-action creates its tag) trigger another workflow run -- a deliberate recursion guard, not a bug. Moves the Docker build into release-please.yml itself, as a `build` job gated on the release-please job's release_created output, so it runs in the same run that already has permission to act (no separate trigger needed). publish.yml becomes a workflow_dispatch-only fallback for re-publishing an existing tag on demand. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the gap you hit:
v0.2.0got tagged + released but no GHCR image was built. Root cause:publish.yml'son: push: tags:trigger can never fire for a tag thatrelease-please-actionitself creates, because it uses the defaultGITHUB_TOKEN-- and GitHub Actions deliberately blocks refs created with that token from triggering further workflow runs (recursion guard).Fix: the Docker build now runs as a
buildjob insiderelease-please.ymlitself (gated on therelease-pleasejob'srelease_createdoutput), in the same run that already has permission to act -- no second trigger involved.publish.ymlis now aworkflow_dispatch-only fallback for manually re-publishing an existing tag.Test plan
pytest -q— 49 passedpublish.ymlwithtag: v0.2.0to publish the image that's currently missing for the existing release🤖 Generated with Claude Code