feat: add GP-age epigenetic clock#188
Conversation
|
Note: The .json.zip extension is misleading - they're actually gzip-compressed JSON files. GPy handles this natively. I noticed this is different than the linear clocks managed as csv's. |
|
I'm not clear what this needs to be ready to merge |
|
I ran into some error locally and I could not repeat it and I looked further into GPy, I just recall it had to do with the .json.zip extension and could not replicate. Let me rebase and make test/format and then take out of draft state. |
8beda2c to
10ec7a9
Compare
Loads successfully, 10 CpG sites
I could not reproduce the original gzip error. GPy's load_model() handles gzip natively despite the misleading .json.zip extension. Tests pass, models load correctly. Rebased on master and marked ready for review. |
sarudak
left a comment
There was a problem hiding this comment.
I think this is ready to merge. Would like to discuss the separation of gpy as an optional dependency.
|
We concluded to leave GPy as a dependency due to compatibility issues and dependencies on other large libraries. |
Summary
pip install biolearn[gpage])Reference