fix: Validate required CpGs for linear methylation models (#123)#192
Merged
marcbal77 merged 3 commits intobio-learn:masterfrom Feb 17, 2026
Merged
Conversation
Member
|
@Sprengmeister-dev This PR looks good to me but needs to have formatting run on it. |
marcbal77
force-pushed
the
fix/missing-cpg-validation
branch
from
69501f5 to
3ae0e5c
Compare
Member
|
LGTM — rebased onto master, ran make format and make test. Also added a MiAge test tolerance for cross-platform float drift that was causing CI failures related to the recently merged MiAge PR. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinearMethylationModelThis fixes #123