Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I have removed the
combine_listsfunction and replaced it withmodifyListto avoid replicating part of base R.A key difference between these functions is that the second argument to
modifyListmust be a list, whilecombine_listsallowed it to beNULL. If the user does not supply driver-specific parameters or initial values, thenddp[['parameters']]orddp[['initial_values']]isNULL, causing a problem. To fix this, I changed these arguments toc(list(), ddp[['parameters']]), etc, which ensures that a (potentially empty) list is always passed.This is in response to a comment from Justin: #16 (comment)