Compress module#1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new compress crate to the workspace, providing a modular compression/decompression framework with an adapter-based design. The implementation supports multiple formats including identity (no compression), deflate, gzip, and bgzf. Additionally, it includes minor refactoring changes to the existing multilock crate.
Key Changes:
- New
compresscrate with trait-based encoder/decoder architecture supporting multiple compression formats via feature flags - Adapter pattern implementation allowing flexible type erasure and constraint handling
- Minor code improvements in
multilock(closure simplification and documentation formatting)
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 30 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Adds compress workspace member and compression-related dependencies (flate2, noodles-bgzf, bitcode) |
workspace/compress/Cargo.toml |
Defines the new compress crate with feature flags for selective format support |
workspace/compress/src/lib.rs |
Provides crate-level documentation with a comprehensive roundtrip usage example |
workspace/compress/src/format.rs |
Implements format detection from file extensions and factory methods for encoders/decoders |
workspace/compress/src/encode/*.rs |
Defines encoding traits, adapters, and implementations for each compression format |
workspace/compress/src/decode/*.rs |
Defines decoding traits, adapters, and implementations for each compression format |
workspace/compress/src/adapter/boxed_sync.rs |
Provides BoxedSync adapter for type-erased trait objects with Send + Sync bounds |
workspace/multilock/src/multi_guard.rs |
Simplifies closure to use constructor shorthand syntax |
workspace/multilock/src/lock.rs |
Removes trailing colon from Safety doc comment header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
compresscrate to the workspace, providing a modular framework for compression and decompression algorithms. The implementation includes an adapter-based design for supporting multiple formats (identity, deflate, gzip, bgzf and biobit serialization support.